Conversation
- Add min="0" attribute to all dims input fields in HTML - Add JavaScript validation to ensure dims >= 0 for all embedding types (Ark, OpenAI, Ollama, Gemini, HTTP) - Validate both embedding_info.dims and openai.request_dims for OpenAI provider - Display error messages when dims values are negative
- Add ThinkingType dropdown selector to model creation modal - Show ThinkingType for: Ark (2), Claude (3), Gemini (11), Qwen (15), Ollama (20) - Ark provider includes Auto option (value 3) - Other providers: Disable (2) and Enable (1) options - Include thinking_type in base_conn_info when submitting model creation - Add i18n strings for ThinkingType options
- Add thinking_type field to model list display - Map thinking_type values: 0=Default, 1=Enable, 2=Disable, 3=Auto - Add getThinkingTypeText() helper function for value mapping - Add i18n translations for thinking_type values in both Chinese and English Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Add condition to display thinking_type field only for supported providers - Supported providers: OpenAI (1), Ark (2), Claude (3), Gemini (11), Qwen (15), DeepSeek (19), Ollama (20) - Now OpenAI and DeepSeek models will properly display the Thinking Type field in model list Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Remove OpenAI (1) and DeepSeek (19) from thinking_type display list - Only display thinking_type for: Ark (2), Claude (3), Gemini (11), Qwen (15), Ollama (20) - OpenAI and DeepSeek model lists will no longer show Thinking Type field Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Remove 'Embedding Request Dims' text input from OpenAI connection UI - Remove openai_embedding_request_dims from initial values - Remove request_dims from OpenAI payload in buildKnowledgePayloadFromInputs - Remove requestDimsVal validation from saveKnowledgeConfig function Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
fanlv
requested review from
N3kox,
Tecvan-fe,
hi-pender,
junwen-lee,
liuyunchao-1998,
lvxinyu-1117,
mrh997,
shentongmartin and
zhuangjie1125
as code owners
N3kox
approved these changes
Oct 30, 2025
hi-pender
approved these changes
Oct 30, 2025
junwen-lee
pushed a commit
that referenced
this pull request
Nov 5, 2025
…2414) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.