Skip to content

STM32duinoBLE enhancement #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2020
Merged

STM32duinoBLE enhancement #1

merged 3 commits into from
Feb 17, 2020

Conversation

fpistm
Copy link

@fpistm fpistm commented Feb 17, 2020

Hi @cparata
here some update I've made to extend robustness and flexibility:

  • Replace boolean with standard bool: avoid several warnings
  • SPISettings managements: instead of storing the frequency and mode. Store directly the SPISettings and avoid to construct it each time a beginTransaction is called.

@cparata cparata merged commit 94a834a into cparata:master Feb 17, 2020
@cparata
Copy link
Owner

cparata commented Feb 17, 2020

Ok, thanks Frederic

@fpistm fpistm deleted the pr-11 branch February 17, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpistm @cparata