-
Notifications
You must be signed in to change notification settings - Fork 771
P1082R0 LWG Issues to be moved in Rapperswil (except issue 3071) #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
31b2230
to
076ae4e
Compare
Regarding P1082R0: Could you double-check that you've applied the edit to meta.trans.ptr? |
source/iostreams.tex
Outdated
copied is operating system dependent. Creation failure because \tcode{p} resolves to an existing directory shall not be | ||
treated as an error. | ||
copied is operating system dependent. | ||
Creation failure because \tcode{p} already exists is not treated as an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"treated as" should be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
\tcode{"\textmu{}s"} should be encoded as UTF-8. Otherwise UTF-16 or UTF-32 is encouraged. | ||
The implementation may substitute other encodings, including \tcode{"us"}. | ||
If \tcode{Period::type} is \tcode{micro}, | ||
but the character U+00B5 cannot be represented in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is the requested wording, but is U+00B5
really how we say things? Wouldn't it be more like "the character whose character short name is B5
"? Or just "the character MICRO SIGN"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zygoloid, any guidance here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U+00B5 is really how the Unicode standard says things. See http://www.unicode.org/versions/Unicode11.0.0/appA.pdf
I see no reason to deviate from the relevant normative reference's notational convention here. Using U+00B5 MICRO SIGN (with MICRO SIGN in small-caps) seems OK too. I'm going to take this as-is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See individual comments.
@tkoeppe: I did not update meta.trans.ptr, because common_type is in meta.trans.other. Furthermore, the underlying text has changed quite a bit here, the salient parts are now in "Note A" and "Note B", below the table. I think I did the best I could given the incoming text, but feel free to make specific improvement suggestions. |
Some of the underlying text has changed, and the edits were applied to the changed text. There is one remaining appearance of 'user-defined type' in [namespace.std], which was not changed.
a28db44
to
9a5f7e9
Compare
9a5f7e9
to
e33f7fa
Compare
I believe Thomas's comments have all been addressed, and I've done a review pass myself. LWG2139 is a bit of a merge conflict disaster, but I've convinced myself we've made all the requested changes. |
Fixes #2129.