[LWG 1] P3504R0 C++ Standard Library Ready Issues#7459
Merged
Conversation
Member
Yes: "Apply the changes for all Ready and Tentatively Ready issues in P3504R0 (C++ Standard Library Ready Issues to be moved in Wrocław, Nov. 2024) to the C++ working paper." |
CaseyCarter
reviewed
Dec 9, 2024
jwakely
reviewed
Dec 13, 2024
jwakely
reviewed
Dec 13, 2024
jensmaurer
added
the
changes requested
jwakely
reviewed
Dec 13, 2024
|
|
||
| // bit reference | ||
| class @\libmember{reference}{vector<bool>}@ { | ||
| constexpr reference() noexcept; |
Member
There was a problem hiding this comment.
For the record, the friend declarations were removed by #6427
jwakely
reviewed
Dec 13, 2024
jwakely
requested changes
Dec 13, 2024
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
Move two occurrences of "only" to later in the sentence, for more goodly Englishing.
Change address to to_address.
Use \libconcept for same_as, twice
jwakely
reviewed
Dec 14, 2024
tkoeppe
force-pushed
the
motions-2024-11-lwg-1
branch
from
7820989 to
6b52bff
Compare
jwakely
requested changes
Dec 16, 2024
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
I've now added suggestions for the remaining issues. Those could be committed directly to the branch, or squashed individually to the relevant commits.
tkoeppe
force-pushed
the
motions-2024-11-lwg-1
branch
2 times, most recently
from
0898ed1 to
3a057d4
Compare
jwakely
reviewed
Dec 16, 2024
tkoeppe
force-pushed
the
motions-2024-11-lwg-1
branch
from
3a057d4 to
af41385
Compare
…rator new should not be constrained
[specialized.algorithms.general] Changed to "function templates" as per #6265.
…_carry_engine code
…ared_for_overwrite/std::allocate_shared_for_overwrite
[ostream.formatted.print] New paragraphs not numbered as indicated since they are part of the \effects clause.
In wording for LWG4044, as per LWG discussion.
… of std::memcpy
…able entity should consider decaying
tkoeppe
force-pushed
the
motions-2024-11-lwg-1
branch
from
af41385 to
20aa7ce
Compare
[optional.assign] Removed "<T>" from declaration to match that in synopsis.
…lloc>)'s nested generator may be ill-formed
…not yet marked freestanding
[template.bitset.general] [vector.bool.pspc] bitset already removed.
tkoeppe
force-pushed
the
motions-2024-11-lwg-1
branch
from
20aa7ce to
5ce6b99
Compare
tkoeppe
force-pushed
the
motions-2024-11-lwg-1
branch
from
5ce6b99 to
71389a0
Compare
jensmaurer
removed
the
changes requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7413.
Notes: I assumed the Tentatively Ready issues were to be applied also.
Fixes cplusplus/papers#2165
Also fixes cplusplus/papers#1983
Also fixes cplusplus/papers#1811
Also fixes cplusplus/papers#1814