Conversation
jensmaurer
left a comment
jensmaurer
left a comment
There was a problem hiding this comment.
Rebased on main and testing.
The "gramwrite" spelling error was not flagged by LaTeX; strange. Is this ever invoked?
The commit message of the main change has a typo "exract".
source/macros.tex
Outdated
|
|
||
| \NewEnviron{simplebnf}{\begin{ncsimplebnf}% | ||
| \BODY% | ||
| \gramwrite{\string\begin{ncsimplebnf}\meaningbody\BODY\string\end{ncsimplebnf}}% |
There was a problem hiding this comment.
| \gramwrite{\string\begin{ncsimplebnf}\meaningbody\BODY\string\end{ncsimplebnf}}% | |
| \gramWrite{\string\begin{ncsimplebnf}\meaningbody\BODY\string\end{ncsimplebnf}}% |
There was a problem hiding this comment.
Yes, "simpebnf" is unused throughout the standard. Please remove.
(We only use "ncsimplebnf".)
There was a problem hiding this comment.
So I suppose we should rename ncsimplebnf and ncrebnf? We can drop the "nc" there if we are reasonably sure that bnf is the only environment we'll ever want extracted.
There was a problem hiding this comment.
I think it's plausible to assume we only ever want "bnf" to be extracted; everything else are either grammar quotes or non-C++ grammar things (such as regex).
There was a problem hiding this comment.
I see, makes sense. Yeah, in that case a global renaming would be plausible (but is by no means urgent or important).
|
"diffpdf" in "Appearance" mode shows no differences. Please merge after fixing the minor findings. |
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
The check.yml commit has an odd summary: "MacOS Linux runner"
Was "Linux" meant to say something else?
|
@jwakely Yeah, sorry, the genesis of this PR is a bit chaotic. I'll apply some of the commits directly and repurpose/rewrite the runner based things appropriately. Thanks! |
tkoeppe
changed the title
(I deleted the wrong word. Initially the commit said "Update MacOS and Linux runners". I meant to delete "Linux", not "Update".) |
The path of the `sed` binary on MacOS has changed going from Intel (macos-13) to M1 (macos-15).
3 participants
No description provided.