[tab:meta.trans.cv] Simplify wording for add_{const,volatile,cv}
#7852
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes the style to west const. Wordings about reference, function, or top-level _cv_-qualified types are moved to notes as they are redundant at least since C++11.
frederick-vs-ja
commented
Apr 24, 2025
Comment on lines
+1716
to
+1719
| \begin{tailnote} | ||
| \keyword{const} has no effect when \tcode{T} is a reference, function, or | ||
| top-level const-qualified type. | ||
| \end{tailnote} |
There was a problem hiding this comment.
I'm not sure whether it's still worthy to talk about reference, function, or top-level cv-qualified types.
Also, I feel that it might make sense to group type_identity with these traits.
jensmaurer
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
These changes look good to me.
For @jwakely to decide whether he wants to have the notes; I don't particularly care either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes the style to west const.
Wordings about reference, function, or top-level cv-qualified types are moved to notes as they are redundant at least since C++11.