[lex] Complete the use of unicode code points #8412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Making this P2 because the direction affirmed for P2843R3 is that we ought to use code points instead of colloquial names like "backslash". |
Contributor
|
Could you reword the commit message to describe the change made by the commit, instead of the wider project (which isn't very descriptive)? |
AlisdairM
force-pushed
the
unicodify_lex
branch
from
7f0f1ff to
69a79fe
Compare
Member
|
@AlisdairM , did you intend to close this? |
Contributor
Author
|
No, I pushed an update that went to the wrong repo --- I am disconnected. |
Member
|
Ack. I had to make this repo private due to the other pull request about ongoing business, and that disconnected all forks. Quite a fall-out. |
Contributor
|
@AlisdairM: I reopened this. |
Contributor
Author
|
I believe that this PR should be visible and open again, with the revised comment message that Thomas asked for, or at least my attempt at such a rewording. |
Completes the task of applying Unicode code point markup to
refer to single characters in normative text.
Replace all remaining uses of backslash as glyph (\) or text
with the corresponding `unicode{005c}{reverse solidus}` markup.
Replace a couple of text reference to single and double quotes
with their corresponding Unicode markup, and similarly for the
glyphs ` and ".
This should compete the last Unicode markup in [lex].
AlisdairM
force-pushed
the
unicodify_lex
branch
from
69a79fe to
9986f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the task of applying Unicode code point markup to
refer to single characters in normative text.
Replace all remaining uses of backslash as glyph () or text
with the corresponding
unicode{005c}{reverse solidus}markup.Replace a couple of text reference to single and double quotes
with their corresponding Unicode markup, and similarly for the
glyphs ` and ".
This should compete the last Unicode markup in [lex].
Resolves #5502