CWG Poll 3b: P3920R0 Wording for NB comment resolution on trivial relocation #8515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisenwave
suggested changes
Nov 13, 2025
Member
Yes, please put those "Fixes NB..." lines into the commit message for posterity. And please do use the format specified here: https://github.com/cplusplus/draft/wiki/Commit-message-format#nb-comment-resolutions "git log" is your friend; we already have plenty of editorial ones. Otherwise looks good. |
AlisdairM
force-pushed
the
p3920R0_remove_trivial_relocation
branch
from
1e93d2c to
801385c
Compare
Member
|
For the commit description, thanks for adding the NB comments. "git log" shows that, historically, we have not repeated "NB" for each element in the list, and we've used ", and" between the penultimate and the last elements of the list. |
Also fixes NB BDS 2-034, CA-133, CA-136, CA-137, CN 6.9.1p9, FR 002-025, US 9-024, US 10-023, US 44-082, US 45-081, US 46-085, US 47-084, and US 73-131 (C++26 CD).
AlisdairM
force-pushed
the
p3920R0_remove_trivial_relocation
branch
from
801385c to
dbbeeba
Compare
tkoeppe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes BDS 2-034
Also fixes CA-133
Also fixes CA-136
Also fixes CA-137
Also fixes CN 6.9.1p9
Also fixes FR-002-025
Also fixes US 9-024
Also fixes US 10-023
Also fixes US 44-082
Also fixes US 45-081
Also fixes US 46-085
Also fixes US 47-084
Also fixes US 73-131
Fixes #8457
Fixes cplusplus/papers#2539
Also fixes cplusplus/nbballot#597
Also fixes cplusplus/nbballot#598
Also fixes cplusplus/nbballot#599
Also fixes cplusplus/nbballot#609
Also fixes cplusplus/nbballot#657
Also fixes cplusplus/nbballot#658
Also fixes cplusplus/nbballot#660
Also fixes cplusplus/nbballot#661
Also fixes cplusplus/nbballot#710
Also fixes cplusplus/nbballot#712
Also fixes cplusplus/nbballot#715
Also fixes cplusplus/nbballot#716
Also fixes cplusplus/nbballot#979