Skip to content

[hive.cons] Fix typo "traits<alloc>" => "traits<Allocator>" #8689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hanickadot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[hive.cons] Fix typo "traits<alloc>" => "traits<Allocator>" #8689

hanickadot wants to merge 2 commits into from
+2 −2

Conversation

@hanickadot
Copy link
Contributor

@hanickadot hanickadot commented Dec 27, 2025 •
edited
Loading

In the precondition it says allocator_traits<alloc> but alloc is name of argument, not the type of allocator.

jensmaurer
jensmaurer requested changes Dec 27, 2025
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

##[error]Overfull \hbox (16.72783pt too wide) in paragraph at lines 8299--8303

needs fixing.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jensmaurer jensmaurer jensmaurer requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

changes requested Changes to the wording or approach have been requested and not yet applied.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanickadot @jensmaurer