Skip to content

replace deprecated calls to FetchContent_Populate #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheLartians merged 9 commits into from
Jul 29, 2024
Merged

replace deprecated calls to FetchContent_Populate #570

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
873bbec
replace deprecated calls to FetchContent_Populate
Avus-c Jul 11, 2024
3e052e8
fix: OPTIONS passed to CPMAddPackage not set
Jul 15, 2024
aff9803
refactor: remove an unnecessary else branch
Jul 15, 2024
82836e6
ci: include cmake 3.30 in test matrix
Jul 18, 2024
bf56eda
fix: forward SOURCE_SUBDIR to FetchContent_Declare
Jul 18, 2024
77dc92f
fix: only set options if download_only is false
Jul 18, 2024
6f2cf67
fix: DOWNLOAD_ONLY test
Jul 18, 2024
0e8ca2a
refactor: always use *_Populate to reduce code paths
Avus-c Jul 19, 2024
b416836
Revert "refactor: always use *_Populate to reduce code paths"
Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
os: [ubuntu-latest, windows-2022, macos-latest]
# we want to ensure compatibility with a recent CMake version as well as the lowest officially supported
# legacy version that we define as the default version of the second-latest Ubuntu LTS release currently available
cmake_version: ['3.16.3', '3.27.5']
cmake_version: ['3.16.3', '3.27.5', '3.30.0']
exclude:
# there seems to be an issue with CMake 3.16 not finding a C++ compiler on windows-2022
- os: windows-2022
Expand Down
26 changes: 10 additions & 16 deletions cmake/CPM.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,10 +862,7 @@ function(CPMAddPackage)
)

if(NOT CPM_SKIP_FETCH)
cpm_declare_fetch(
"${CPM_ARGS_NAME}" "${CPM_ARGS_VERSION}" "${PACKAGE_INFO}" "${CPM_ARGS_UNPARSED_ARGUMENTS}"
)
cpm_fetch_package("${CPM_ARGS_NAME}" populated)
cpm_fetch_package("${CPM_ARGS_NAME}" populated ${CPM_ARGS_UNPARSED_ARGUMENTS})
if(CPM_SOURCE_CACHE AND download_directory)
file(LOCK ${download_directory}/../cmake.lock RELEASE)
endif()
Expand Down Expand Up @@ -979,17 +976,7 @@ function(CPMGetPackageVersion PACKAGE OUTPUT)
)
endfunction()

# declares a package in FetchContent_Declare
function(cpm_declare_fetch PACKAGE VERSION INFO)
if(${CPM_DRY_RUN})
cpm_message(STATUS "${CPM_INDENT} Package not declared (dry run)")
return()
endif()

FetchContent_Declare(${PACKAGE} ${ARGN})
endfunction()

# returns properties for a package previously defined by cpm_declare_fetch
# returns properties for a package previously defined by cpm_fetch_package
function(cpm_get_fetch_properties PACKAGE)
if(${CPM_DRY_RUN})
return()
Expand Down Expand Up @@ -1071,7 +1058,14 @@ function(cpm_fetch_package PACKAGE populated)
string(TOLOWER "${PACKAGE}" lower_case_name)

if(NOT ${lower_case_name}_POPULATED)
FetchContent_Populate(${PACKAGE})
FetchContent_Populate(
${PACKAGE}
QUIET
SOURCE_DIR "${CPM_FETCHCONTENT_BASE_DIR}/${lower_case_name}-src"
BINARY_DIR "${CPM_FETCHCONTENT_BASE_DIR}/${lower_case_name}-build"
SUBBUILD_DIR "${CPM_FETCHCONTENT_BASE_DIR}/${lower_case_name}-subbuild"
${ARGN}
)
set(${populated}
TRUE
PARENT_SCOPE
Expand Down