doc: warn users that PATCHES may not work properly when CPM_SOURCE_CACHE is unset. #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLartians
approved these changes
Dec 22, 2024
Member
TheLartians
left a comment
TheLartians
left a comment
There was a problem hiding this comment.
Thanks for the extra documentation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #577 is difficult to debug once triggered given that it is undocumented. It is likely to affect virtually all developers who rely on PATCHES with CPM_SOURCE_CACHE unset. If there is no plan to resolve it quickly, and if the assumption is that the users should set CPM_SOURCE_CACHE when they use PATCHES, then it should be documented as such.