update build.yml and add .gitignore #54
Conversation
shenxianpeng
force-pushed
the
fix-macos-buiild
branch
from
0c3a8d9 to
5e4853d
Compare
WalkthroughThe changes update the GitHub Actions workflow by downgrading the macOS runner version, switching to GCC 14 compilers, adding a CMake build target, and enhancing the patching process for CMake implicit link info files on macOS. Additionally, a Changes
Possibly related PRs
Suggested labels
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.gitignore (1)
1-3: Ignore common Python virtual environment directories
The.gitignorecorrectly excludesvenv/and./venv/to prevent committing local virtual environments. Consider adding other common Python ignores such as__pycache__/,.pytest_cache/,.mypy_cache/, and.envfiles for a more comprehensive ignore list..github/workflows/build.yml (2)
91-91: Scope LLVM targets explicitly for macOS build
Adding-DLLVM_TARGETS_TO_BUILD=X86limits the build to the x86 backend, which aligns with the Intel runner. If ARM (Apple Silicon) or other architectures need to be supported in the future, consider parameterizing this argument in the matrix to includeX86;ARM(or other targets) based on the runner.
145-151: Enhance robustness of patch loop for CMake files
The new loop dynamically patches allCMakeParseImplicitLinkInfo.cmakefiles under the Homebrew prefix, which is a solid improvement. To handle file paths with spaces and ensure early failure on errors, consider switching to a null-delimitedfindandwhileloop, and addingset -e:- FILES=$(find "$BREW_PREFIX" -name CMakeParseImplicitLinkInfo.cmake) - for file in $FILES; do + set -e + while IFS= read -r -d '' file; do echo "Patching $file" sed -i.backup 's/gcc_eh.*|/gcc_eh.*|gcc_ext.*|/g' "$file" - done + done < <(find "$BREW_PREFIX" -name CMakeParseImplicitLinkInfo.cmake -print0)This approach avoids word-splitting issues and ensures the script exits on patch failures.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build.yml(3 hunks).gitignore(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: build (8, windows)
- GitHub Check: build (9, windows)
- GitHub Check: build (12, linux)
- GitHub Check: build (12, windows)
- GitHub Check: build (12.0.1, windows)
- GitHub Check: build (20, windows)
- GitHub Check: build (14, windows)
- GitHub Check: build (14, linux)
- GitHub Check: build (16, windows)
- GitHub Check: build (17, windows)
- GitHub Check: build (19, windows)
🔇 Additional comments (1)
.github/workflows/build.yml (1)
65-65: Verify compatibility of macos-13 runner
The runner has been changed frommacos-14tomacos-13to target Intel-based macOS. Please confirm that all required Xcode versions and Homebrew packages are available onmacos-13and update the CI documentation or test matrix if macOS ARM (Apple Silicon) support is needed.
Summary by CodeRabbit