Halstead volume metric tests fail due to maven use not declared in config

[AntonProkopyev]

The HV metric needs refinement.

For now:

• tests for it aren't running
• implementation uses maven
• not stated in config

Code: https://github.com/cqfn/aibolit/tree/master/aibolit/metrics/hv

[AntonProkopyev]

@yegor256 FYI

[yegor256]

@AntonProkopyev definitely, let's fix it!

[0crat]

@AntonProkopyev Great job reporting that new bug! 🐛 As per our policy, you've earned 12 points for this valuable contribution. Your keen eye helps elevate our project's quality. Remember, if you spot anything else in the repository that doesn't look up to par, don't hesitate to report it. Every bug you find is rewarded, so keep them coming! Your current balance stands at +72 points. Keep up the excellent work!

[serasma]

Hello Yegor, I'd like to contribute to this issue. Just a couple of points to clarify:

1. About maven dependency: is it a good solution that if the .jar file is missing there will be FileNotFoundError exception raised?
2. As I understand, metrics follow the MN naming convention, where N is index of the metric. So, the hv metric should be stated as M12 in the aibolit/config.py, right?

[yegor256]

@AntonProkopyev WDYT? (for some reason the question was addressed to me, while this ticket is yours)

[AntonProkopyev]

@onemoreslacker Hello!

1. About maven dependency: is it a good solution that if the .jar file is missing there will be FileNotFoundError exception raised?

For now we are leading to avoid maven dependency and provide a pure python metric implementation.

2. As I understand, metrics follow the MN naming convention, where N is index of the metric. So, the hv metric should be stated as M12 in the aibolit/config.py, right?

I am not sure about exact number. But metrics should follow this convention. And must implement Metric protocol, defined near config.

[serasma]

regarding first point: you mentioned that implementation uses maven. i thought that i should erase it from aibolit/hv/main.py. something like the following:

diff --git a/aibolit/metrics/hv/main.py b/aibolit/metrics/hv/main.py
index 116fc7b4..dad76c65 100644
--- a/aibolit/metrics/hv/main.py
+++ b/aibolit/metrics/hv/main.py
@@ -21,9 +21,7 @@ class HVMetric():
         path = os.path.abspath(os.path.join(os.path.dirname(__file__), '..',
                                'halsteadvolume/target/java-project-1.0-SNAPSHOT.jar'))
         if not os.path.isfile(path):
-            hvpath = os.path.abspath(os.path.join(os.path.dirname(__file__), '..',
-                                                  'halsteadvolume'))
-            subprocess.run(['mvn', 'clean', 'package'], cwd=hvpath, check=True)
+            raise FileNotFoundError(f'JAR file not found at {path}, please build it first.')
         result = subprocess.run(['java', '-jar', path, self.input],
                                 stdout=subprocess.PIPE, check=True)
         out = result.stdout.decode('utf-8')

or maybe i didn't understand your point correctly.

[AntonProkopyev]

@onemoreslacker Hello! #849 and #848 can be used as a reference.

Just erasing maven in metric code does not make HV metric work.

[marinka-aa]

@yegor256 provided in #1243