Skip to content

#955: Consolidate style checks under make lint#1226

Merged
yegor256 merged 1 commit into
cqfn:masterfrom
marinka-aa:fix-issue-955-style-ci
Jun 25, 2026
Merged

#955: Consolidate style checks under make lint#1226
yegor256 merged 1 commit into
cqfn:masterfrom
marinka-aa:fix-issue-955-style-ci

Conversation

@marinka-aa

@marinka-aa marinka-aa commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated the project’s linting setup to include an additional code-quality check in the main lint command.
    • Removed several separate automated lint checks from the CI pipeline, simplifying background validation.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc936557-eef4-4a6a-830b-256f4d900e91

📥 Commits

Reviewing files that changed from the base of the PR and between a3ace02 and d980bd6.

📒 Files selected for processing (4)
  • .github/workflows/flake8.yml
  • .github/workflows/pylint.yml
  • .github/workflows/ruff.yml
  • Makefile
💤 Files with no reviewable changes (3)
  • .github/workflows/ruff.yml
  • .github/workflows/flake8.yml
  • .github/workflows/pylint.yml

📝 Walkthrough

Walkthrough

The PR removes the dedicated flake8, pylint, and ruff GitHub Actions workflows and updates the Makefile lint aggregate target to run ruff alongside flake8, pylint, and mypy.

Changes

Lint workflow consolidation

Layer / File(s) Summary
Makefile lint wiring and workflow removal
Makefile, .github/workflows/flake8.yml, .github/workflows/pylint.yml, .github/workflows/ruff.yml
The lint target adds ruff, and the separate lint workflow files are removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • cqfn/aibolit#817: It updates the same Makefile lint/ruff machinery, including how the ruff target is invoked.

Suggested reviewers

  • ivanovmg

Poem

I hopped through lint with a twitchy nose,
ruff joined the meadow where clean code grows.
Old workflows drifted off at dawn,
while mypy kept the rhythm on.
Thump-thump—our checks now sing, and on! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes consolidating lint/style checks under the Makefile lint target and removing separate CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yegor256
yegor256 merged commit 6e7a5b6 into cqfn:master Jun 25, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants