-
Notifications
You must be signed in to change notification settings - Fork 889
Description
Version/revision of the library used
master (817517c)
Describe the bug
Setting "Beep: On" doesn't toggle the beep state on my unit.
To Reproduce
Set "Beep: On" when sending a Samsung IR message.
Example code used
N/A
Expected behaviour
The code should spit out a valid IR message that toggles the beep state.
Output of raw data from IRrecvDumpV2.ino or V3 (if applicable)
I can upload a dump if you need it - however I've figured out what's causing the issue and fixed it in #1668 . Also I don't want to raise your blood pressure by posting VS1838b dumps.
What brand/model IR demodulator are you using?
I think it's called B14Y, however somehow the results from that are even worse than from my VS1838b
If VS1838b: That is likely your problem. Please buy a better one & try again. Reporting a capture or decode issue when you use one of these is effectively wasting our & your time. See the FAQ
Yes, I agree, it's a piece of ****, however it's been working fine with 30% tolerance for all captures.
Also, I've put the whole circuit in a long, dark box, gave it a few headpats and the results are good.
Circuit diagram and hardware used (if applicable)
N/A
I have followed the steps in the Troubleshooting Guide & read the FAQ
Yes
Has this library/code previously worked as expected for you?
No, the beep never worked
Other useful information
When Sending "Beep: On", the last nibble will be set to 2 (0010), while it's required to be set to 4 (0100). This is fixed in #1668 , however I have no knowledge of C++, so I'll need you to take a look at my PR to see if I just broke the whole thing / broke compatibility with other models.
Using the fix in the PR makes my unit beep like it's supposed to, exactly like the original remote.