v2.8.6 release #2020
Merged
v2.8.6 release #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_v2.8.6 (20230727)_ **[Bug Fixes]** - Ensure `IRCoolixAC::toCommon()` returns `kNoTempValue` when no sensor temp is detected. (#2015 #2012) - Fix compilation dependency of LG on Samsung send protocol (#2011 #2010) - Fix missing parameter in call to `IRac::gree()` (#2008 #2007) **[Features]** - IRac: Ensure the `sleep` parameter is used for the `FUJITSU_AC` protocol. (#1992 #1991) **[Misc]** - Allow the BlynkIRRemote.ino code to compile again. (#2016) - do not list WHIRLPOOL_AC unconditionally as supported protocol (#2003) - IRUtils:typeToString() — simplify (#2002) - Fix brand Green -> Gree (#1994) - Fix undefined `std::round` compilation error (#1989)
NiKiZe
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.8.6 (20230727)
[Bug Fixes]
IRCoolixAC::toCommon()returnskNoTempValuewhen no sensor temp is detected. ([BUG] EnsureIRCoolixAC::toCommon()returnskNoTempValuecorrectly. #2015 About Coolix #2012)IRac::gree()([BUG] Fix missing parameter in call toIRac::gree()#2008 Gree protocol sending issue using IRac class #2007)[Features]
sleepparameter is used for theFUJITSU_ACprotocol. (Ensure thesleepparameter is used for theFUJITSU_ACprotocol. #1992 I ended up having the same problem, and realised the root cause: in sendAc() in src/IRac.cpp, we are not passing the sleep parameter. Specifically: #1991)[Misc]
BlynkIRRemote.inocode to compile again. (Allow the BlynkIRRemote.ino code to compile again. #2016)WHIRLPOOL_ACunconditionally as supported protocol (IRac::isProtocolSupported() — do not list WHIRLPOOL_AC unconditionally as supported protocol #2003)std::roundcompilation error (Fix undefinedstd::roundcompilation error #1989)