Skip to content

Basic DAIKIN 160bit send and decode. #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2019
Merged

Basic DAIKIN 160bit send and decode. #754

merged 1 commit into from
Jun 16, 2019

Conversation

@crankyoldgit
Copy link
Owner

@crankyoldgit crankyoldgit commented Jun 15, 2019

  • sendDaikin160() & decodeDaikin160() implemented, inc checksums.
  • Unit tests for sending and basic decoding. Using captured data.
  • Add support to example code as needed.

FYI @pasna

For #731

@crankyoldgit
Basic DAIKIN 160bit send and decode.
9ea974e 
- `sendDaikin160()` & `decodeDaikin160()` implemented, inc checksums.
- Unit tests for sending and basic decoding. Using captured data.
- Add support to example code as needed.

FYI @pasna

For #731
@crankyoldgit crankyoldgit self-assigned this Jun 15, 2019
@pasna
Copy link
Contributor

pasna commented Jun 15, 2019

@crankyoldgit I have tested with my Daikin AC, this is wonderful. It works on IRMQTTServer "Home" too. Do you plan to add coding on the "Aircon" ? Please accept my sincere appreciation.
Have a good weekend.

@crankyoldgit
Copy link
Owner Author

crankyoldgit commented Jun 15, 2019

Do you plan to add coding on the "Aircon" ?

Once you've finished with your analysis and coding, let me know and I'll merge/convert your code into the main library.
I've done so many reverse engineering of a/c codes that I really don't want to do the analysis anymore. So I won't be doing any of the primary work. Happy to help and give advice.
Given how similar the other daikin protocols are, you can probably pinch code from them to help you support the settings.

Once you're done, I'll certainly add it to the "Aircon" page and common a/c system for you.

sillyfrog
sillyfrog approved these changes Jun 16, 2019
View reviewed changes
Copy link
Collaborator

@sillyfrog sillyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but as it's just a basic start, hard to test.

@crankyoldgit
Copy link
Owner Author

crankyoldgit commented Jun 16, 2019

@sillyfrog That's why we have unit tests to emulate sending and receiving with raw data.
@pasna has at least confirmed receiving works. ;-)

@crankyoldgit
Copy link
Owner Author

crankyoldgit commented Jun 16, 2019

And @sillyfrog, thanks for the prompt code review.

@crankyoldgit crankyoldgit merged commit dd6b56f into master Jun 16, 2019
@crankyoldgit crankyoldgit deleted the daikin_ARC423A5 branch June 16, 2019 06:43
crankyoldgit added a commit that referenced this pull request Jun 16, 2019
@crankyoldgit
v2.6.2 release
54020e7 
_v2.6.2 (20190616)_

**[Features]**
- Initial support for the ESP32 architecture & boards. (#742)
- Add changable GPIO settings to IRMQTTServer. (#730)
- IRMQTTServer: Enforce a repeat for all Coolix calls (#752)
- Basic DAIKIN 160bit send and decode. (#754)
- Add example code for a Smart(er) IR Repeater. (#740)
- Enforce Samsung A/C Quiet & Powerful mutual exclusivity.

**[Misc]**
- IRMQTTServer: Add some memory alloc safety checks. (#749)
- Move some ToString() functions to IRac.cpp (#748)
- Increase tolerance value for TCL112AC protocol. (#745)
- Fix compiler warning in IRutils_test.cpp (#756)
- Scrape Supported Protocols and generate SupportedProtocols.md (#755)
- Make supported device info more organised. (#753)
@crankyoldgit crankyoldgit mentioned this pull request Jun 16, 2019
Merged
crankyoldgit added a commit that referenced this pull request Jun 16, 2019
@crankyoldgit
v2.6.2 release (#759)
4af3126 
_v2.6.2 (20190616)_

**[Features]**
- Initial support for the ESP32 architecture & boards. (#742)
- Add changable GPIO settings to IRMQTTServer. (#730)
- IRMQTTServer: Enforce a repeat for all Coolix calls (#752)
- Basic DAIKIN 160bit send and decode. (#754)
- Add example code for a Smart(er) IR Repeater. (#740)
- Enforce Samsung A/C Quiet & Powerful mutual exclusivity.

**[Misc]**
- IRMQTTServer: Add some memory alloc safety checks. (#749)
- Move some ToString() functions to IRac.cpp (#748)
- Increase tolerance value for TCL112AC protocol. (#745)
- Fix compiler warning in IRutils_test.cpp (#756)
- Scrape Supported Protocols and generate SupportedProtocols.md (#755)
- Make supported device info more organised. (#753)
@crankyoldgit
Copy link
Owner Author

crankyoldgit commented Jun 16, 2019

FYI, the above code changes have been included in the new v2.6.2 release.

@pasna
Copy link
Contributor

pasna commented Jun 17, 2019

@crankyoldgit Thank you and have a great day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sillyfrog sillyfrog sillyfrog approved these changes

@rahuljawale rahuljawale Awaiting requested review from rahuljawale

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crankyoldgit @pasna @sillyfrog