Spec: use inbuild gobuildid to generate build id with -B option #4595
Conversation
|
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
gobuildid is documented here https://pkg.go.dev/cmd/link
There's a gobuilid typo in the short log (missing 'd')
Imo, the current random ID approach does not deserve the "hack" qualifier even if it needs to be improved by this commit.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As of now, a random build ID (20 digits) generated and added to binary but with go-1.23.x it is causing following issue in the CI ``` /usr/lib/golang/pkg/tool/linux_amd64/link: -B option too long (max 16 digits): 0x1c32bce09ea23923c57a3cca65fd91e377714192 ``` Looks like `gobuilid` can be used to generate it with -B options without random ID and it can work without isssue for CI - golang/go#70380 ``` $ readelf -n out/linux-amd64/crc Displaying notes found in: .note.gnu.property Owner Data size Description GNU 0x00000010 NT_GNU_PROPERTY_TYPE_0 Properties: x86 ISA needed: x86-64-baseline Displaying notes found in: .note.gnu.build-id Owner Data size Description GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID bitstring) Build ID: f1c4d1d70301bc12737353faf4ee38de3cd25930 ```
praveenkumar
force-pushed
the
fix_rpm_build
branch
from
799e4df to
d5f3216
Compare
|
New changes are detected. LGTM label has been removed. |
praveenkumar
changed the title
As of now, a random build ID (20 digits) generated and added to binary but with go-1.23.x it is causing following issue in the CI
Looks like
gobuilidcan be used to generate it with -B options without random ID hack and it can work without isssue for CI