test(rest_executor): add unit test for handleRun #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criyle
reviewed
May 20, 2025
Comment on lines
69
to
79
| func mapEqual(a, b map[string]string) bool { | ||
| if len(a) != len(b) { | ||
| return false | ||
| } | ||
| for k, v := range a { | ||
| if b[k] != v { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } |
Comment on lines
145
to
148
| logger, err := zap.NewDevelopment(zap.Development()) | ||
| if err != nil { | ||
| t.Fatalf("Failed to create logger: %v", err) | ||
| } |
There was a problem hiding this comment.
You may use zaptest.NewLogger to create test logger.
Comment on lines
39
to
37
| func (m *mockWorker) Cancel(_ context.Context, _ string) error { | ||
| return nil | ||
| } | ||
|
|
||
| func (m *mockWorker) Close() { | ||
| } | ||
|
|
||
| func (m *mockWorker) Start() { | ||
| } | ||
|
|
||
| func (m *mockWorker) Execute(_ context.Context, _ *worker.Request) <-chan worker.Response { | ||
| return nil | ||
| } | ||
|
|
||
| func (m *mockWorker) Stat() worker.Stat { | ||
| return worker.Stat{ | ||
| Queue: 10, | ||
| Running: 2, | ||
| } | ||
| } | ||
|
|
||
| func (m *mockWorker) Shutdown() { | ||
| } |
There was a problem hiding this comment.
You can just embed an interface and override the part you want to test to avoid duplicates. For example,
type mockWorker struct {
Result worker.Result
worker.Worker
}
|
@criyle You are right. I will update my code. |
DNEGEL3125
force-pushed
the
test-cmd-handler
branch
from
c084ef0 to
2fb4dff
Compare
criyle
reviewed
May 21, 2025
Comment on lines
31
to
37
| rtCh := make(chan worker.Response) | ||
| go func() { | ||
| rtCh <- worker.Response{ | ||
| RequestID: req.RequestID, | ||
| Results: []worker.Result{m.Result}, | ||
| } | ||
| }() |
There was a problem hiding this comment.
You don't need a go routine for this as you can create a buffered channel:
rtCh := make(chan worker.Response, 1)
rtCh <- worker.Response{...
}Also, do we want to check the request like what we did for results (assertWorkerResultEqualsModelResult) to ensure the api endpoint is parsing the request correctly?
There was a problem hiding this comment.
Maybe, but I haven't figured out how to test the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.