Skip to content

check for newlines in test #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

check for newlines in test #940

merged 1 commit into from
Jul 11, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner July 11, 2022 18:31
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Jul 11, 2022
Alexhuszagh
Alexhuszagh reviewed Jul 11, 2022
View reviewed changes
Alexhuszagh
Alexhuszagh approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@Alexhuszagh Alexhuszagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 11, 2022

Build succeeded:

@bors bors bot merged commit 37d4252 into cross-rs:main Jul 11, 2022
@Alexhuszagh
Copy link
Contributor

We're going to need to fix this: it's too active in the files it chooses. It checks files ignored by .gitignore, including binary files, and files locally ignored in .git/info/exclude.

@Emilgardis Emilgardis added this to the v0.3.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Emilgardis @Alexhuszagh