remove actions-rs #951
remove actions-rs #951
Conversation
|
this follows the general consensus as discussed in actions-rs/toolchain#216 it also adds a matcher, which would otherwise be gone |
.github/actions/setup-rust/rust.json
Outdated
| { | ||
| "regexp": "^([\\s->=]*(.*):(\\d*):(\\d*)|.*)$", | ||
| "file": 2, | ||
| "line": 3, | ||
| "column": 4 | ||
| } |
There was a problem hiding this comment.
| { | |
| "regexp": "^([\\s->=]*(.*):(\\d*):(\\d*)|.*)$", | |
| "file": 2, | |
| "line": 3, | |
| "column": 4 | |
| } | |
| { | |
| "regexp": "^([\\s->=]*(.*):(\\d*):(\\d*)|.*)$", | |
| "file": 2, | |
| "line": 3, | |
| "column": 4 | |
| }, | |
| { | |
| "regexp": "^\\d* *(\\||=)(.*)$", | |
| "message": 0, | |
| "loop": true | |
| } |
I wanted it to be this, but it's not possible due to actions/toolkit#319 (which should probably be re-opened or re-issued)
There was a problem hiding this comment.
technically, this would be possible if it was possible for cargo/rustc to output json diagnostics and human diagnostics, the error annotations in the log would be strange however.
Emilgardis
force-pushed
the
rust-ci
branch
3 times, most recently
from
069ac8c to
99fb540
Compare
|
bors r=@Alexhuszagh |
951: remove actions-rs r=Alexhuszagh a=Emilgardis This essentially removes all actions-rs actions and replaces it with what is needed. Reason for this is due to actions-rs being seemingly unmaintained Co-authored-by: Emil Gardström <[email protected]>
|
Build failed: |
|
bors try --target x86_64-unknown-linux-gnu will squash (and rebase) on success) |
tryBuild succeeded: |
|
bors try --target x86_64-unknown-linux-gnu going to give it a careful re-review, but looks good so far. |
tryBuild succeeded: |
|
Relatedly, but not necessarily relevant for this particular PR, I have been thinking about creating a |
That sounds good, it is possible to use https://github.com/taiki-e/install-action for now, but would be neat to have, and easy to support 👍🏼 |
|
Neat, didn't know about https://github.com/taiki-e/install-action. |
|
Still looks good after #1033, am I free to merge this @Emilgardis? |
|
Yep @Alexhuszagh |
|
bors r=Alexhuszagh,reitermarkus |
|
Build failed: |
|
bors try --target *windows-msvc |
|
bors try --target *windows-msvc |
|
bors try --target *windows-msvc |
tryAlready running a review |
|
bors try- |
|
bors try- |
tryBuild failed: |
|
bors try --target *windows-msvc |
tryBuild succeeded: |
|
it works!
|
|
Build succeeded: |
This essentially removes all actions-rs actions and replaces it with what is needed.
Reason for this is due to actions-rs being seemingly unmaintained