Skip to content

Conversation

@andzejsw
Copy link
Contributor

Fix null authextra data in TicketAuth scenario.

@andzejsw
Copy link
Contributor Author

Fix for issue: #561

@om26er
Copy link
Contributor

om26er commented Nov 26, 2024

might make sense to do a similar treatment for cra auth as well

@andzejsw
Copy link
Contributor Author

might make sense to do a similar treatment for cra auth as well

It already has correct implementation of authextra.

Ekrānuzņēmums 2024-11-26 184749

@andzejsw
Copy link
Contributor Author

might make sense to do a similar treatment for cra auth as well

Oh you meant ChallengeResponseAuth. Will do it now.

Copy link
Contributor

@om26er om26er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oberstet oberstet merged commit 5f13baa into crossbario:master Nov 28, 2024
1 check passed
@oberstet
Copy link
Contributor

thanks for contributing @andzejsw , and thanks for reviewing @om26er !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants