Fix/allow non standard convention tgz #288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertoec
requested review from
erhancagirici,
lsviben,
sergenyalcin,
turkenf and
turkenh
as code owners
…t tgz names Signed-off-by: Alberto Estévez <[email protected]>
Signed-off-by: Alberto Estévez <[email protected]>
albertoec
force-pushed
the
fix/allow-non-standard-convention-tgz
branch
from
80374d7 to
dd6592b
Compare
Signed-off-by: Alberto Estévez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes an issue regarding helm charts not honoring naming convention. Originally, the provider will generate the expected tgz name directly as
filename := fmt.Sprintf("%s-%s.tgz", spec.Name, spec.Version). The new implementation gets the name of the .tgz directly from the downloaded file, avoiding the hard-coding of the tgz file.Fixes #106
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested on live cluster deploying charts with standard and non-standard convention names.