fix native modules#65
Merged
heyman333 merged 1 commit intocrossplatformkorea:masterfrom Oct 8, 2019
bang9:master
Merged
Conversation
- Use Native Map and Dictionary for javascript object - Rename profile properties (profile_image_url, thumbnail_image_url, is_kakaotalk_user, is_email_verified) - Support real-time profile (nickname, profile image, thumbnail image)
heyman333
requested review from
hyochan and
sunkibaek
and removed request for
hyochan
|
@bang9 감사합니다! |
heyman333
requested review from
heyman333
and removed request for
hyochan and
sunkibaek
Contributor
Author
변경되어있습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@heyman333 작업하면서 몇가지 상이한 프로퍼티 이름을 변경했습니다.
프로미스 PR 까지 합쳐서, 버전을 2.0.0 으로 릴리즈하고, breaking changes 추가하는게 좋을 것 같아요!
Use Native Map and Dictionary for javascript object
불필요한 JSON Parsing 과정 제거
Rename profile properties
카카오 응답결과와 상이한 변수명들 변경
Support real-time profile
최신 카카오 SDK 에서 제공하는, 실시간 프로필 지원 (
nicknameprofile imagethumbnail image)Update doc
iOS
is_kakaotalk_user외 세가지 항목 지원 목록 업데이트is_kakaotalk_user, is_email_verified등 권한이 필요한 항목들 공식문서에 따른 설명 추가