This repository was archived by the owner on Apr 3, 2020. It is now read-only.
Page Visibility API: visibilitychange on Windows screen lock/unlock #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with astojilj/chromium-crosswalk@6910fe5 as its head.
|
Contributor
Author
|
I don't like the patch - it doesn't cover the case when another opaque window is covering the page fully but it only covers screen lock. Updating it... |
Contributor
Author
|
@darktears Updated the signatures to make them more common. Patch is still handling screen lock only. Could you please review this? Thanks. |
Contributor
|
@astojilj that's ok to land it here but do you think that Google would be interested to have the patch upstream. It sound legit to me that when I lock the screen the app get the event and can pause a game say. @pozdnyakov any other feedback? |
Contributor
Author
|
About upstream: initiated the CL discussion here: |
| } | ||
|
|
||
| void NativeViewHost::OnSoftVisibilityChanged(bool visible) { | ||
| if (!native_view_ || !native_wrapper_.get()) |
Contributor
There was a problem hiding this comment.
nit: .get()is not needed
Contributor
Author
There was a problem hiding this comment.
I would keep it - as it is on 3 other places in the same file like that if ... native_wrapper_.get()
BUG=XWALK-5503 Some OSs (e.g. Windows and Linux) don't mark windows as hiden on screen lock or when other opaque windows fully cover them. Note that e.g. OSX and Android do this while Windows and Linux don't. OnSoftVisibilityChanged enables that OS window state is kept as is (on Linux and Windows) and that e.g. power saving PageVisibility API is still properly triggered. The first patch here targets Windows and screen lock. branch pagevis
|
Testing patch series with astojilj/chromium-crosswalk@9e10775 as its head.
|
Contributor
Author
|
@pozdnyakov Thanks. Updated patch; 2 issues fixed, didn't act on some of the nits. |
Contributor
|
lgtm |
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
Fixes the issue with the test on 10.10 for the commit: https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d1c251559a400 BUG=544307 Review URL: https://codereview.chromium.org/1650713003 [email protected] Cr-Commit-Position: refs/heads/master@{#373695} (cherry picked from commit cae2257) Review URL: https://codereview.chromium.org/1681463003 . Cr-Commit-Position: refs/branch-heads/2623@{#321} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
Page Visibility API: visibilitychange on Windows screen lock/unlock
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Previously MediaWebContentsObserver DCHECKed that an active player was never added twice. To avoid complicated logic in WMPI to keep track of when it's okay to send a playing notification to MediaWebContentsObserver, now it's allowed to send it more than once. BUG=595903, 595970 Review URL: https://codereview.chromium.org/1810213002 Cr-Commit-Position: refs/heads/master@{#382098} (cherry picked from commit 73fd2eb) Review URL: https://codereview.chromium.org/1821753002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#321} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
fujunwei
pushed a commit
to fujunwei/chromium-crosswalk
that referenced
this pull request
May 27, 2016
> [DevTools] Reset tooltip on resize. > > This prevents body being scrolled because of absoultely positioned tooltip. > > BUG=567454 > > Review URL: https://codereview.chromium.org/1502383003 > > Cr-Commit-Position: refs/heads/master@{#363733} TBR=pfeldman (cherry picked from commit 27f8f7e) Review URL: https://codereview.chromium.org/1518983002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#321} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
BUG=618506 Review-Url: https://codereview.chromium.org/2050303003 Cr-Commit-Position: refs/heads/master@{#398995} (cherry picked from commit bb1df9d) Review URL: https://codereview.chromium.org/2062563002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#321} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
This fix sets the content description on the view for each menu item in the bottom nav menu instead of the menu item itself. Setting content description on menu items is only available in API 26. Bug: 763067 Change-Id: I7b3ef1eec846159a3e7ffa983956937b1ea65dc0 Reviewed-on: https://chromium-review.googlesource.com/671652 Reviewed-by: Theresa <[email protected]> Commit-Queue: Troy Hildebrandt <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#502702} TBR: [email protected] Reviewed-on: https://chromium-review.googlesource.com/673303 Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#321} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=XWALK-5503
Some OSs (e.g. Windows and Linux) don't mark windows as hidden on screen
lock or when other opaque windows fully cover them.
Note that e.g. OSX and Android do this while Windows and Linux don't.
OnSoftVisibilityChanged enables that OS window state is kept as is (on
Linux and Windows) and that e.g. power saving PageVisibility API is still
properly triggered.
The first patch here targets Windows and screen lock.