Skip to content

Use CMAKE_MSVC_RUNTIME_LIBRARY for the MSVC PCRE2 static library #15802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Use CMAKE_MSVC_RUNTIME_LIBRARY for the MSVC PCRE2 static library #15802

merged 1 commit into from
May 23, 2025

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API kind:regression Something that used to correctly work but no longer works topic:infrastructure/ci labels May 20, 2025
@straight-shoota straight-shoota added this to the 1.17.0 milestone May 20, 2025
@straight-shoota straight-shoota merged commit bc46ac2 into crystal-lang:master May 23, 2025
38 checks passed
@HertzDevil HertzDevil deleted the bug/msvc-pcre2-static branch May 23, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure/ci
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota