-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Rename Process kill methods to signal [by @jan-zajic] #9006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Benoit de Chezelles <[email protected]>
straight-shoota
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up 👍
I've just some minor wording suggestions, to be a bit more precise (and also align with the existing documentation).
|
@oprypin Why did you remove the example which included specs for |
|
@straight-shoota , #8642 (comment) Funnily enough, that spec is exactly the same as the one preceding it, as kill and terminate are the same thing for now |
|
I see. We could still run |
|
(make sure to squash when merging) |
Co-authored-by: Jan Zajic <[email protected]> Co-authored-by: Jan Zajic <[email protected]> Co-authored-by: Benoit de Chezelles <[email protected]>
Closes #8642. I'm re-creating the PR to be able to resolve outstanding comments.
This probably should be squash-merged, with the above message.