Skip to content

Issue #194: Change --args to match 'gdb --args'. 'cmd' now only takes program name. #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2018
Merged

Issue #194: Change --args to match 'gdb --args'. 'cmd' now only takes program name. #198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5a8abd
Issue #194: Change --args to match 'gdb --args'. 'cmd' now only takes…
fritzr May 21, 2018
caa69a4
Use mutex group for --args|cmd and fix cmd to use a list type.
fritzr May 28, 2018
d5d55b9
Update --args help text
fritzr May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions gdbgui/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,22 +761,11 @@ def main():
parser = argparse.ArgumentParser(description=__doc__)

gdb_group = parser.add_argument_group(title="gdb commands")
args_group = parser.add_mutually_exclusive_group()
network = parser.add_argument_group(title="gdbgui network settings")
security = parser.add_argument_group(title="security settings")
other = parser.add_argument_group(title="other settings")

gdb_group.add_argument(
"cmd",
nargs="*",
help="The binary and arguments to run in gdb. Example: './mybinary myarg -flag1 -flag2'",
default=[],
)
gdb_group.add_argument(
"--args",
nargs="+",
help='Alias for cmd argument above. Example: gdbgui --args "./mybinary myarg -flag1 -flag2"',
default=[],
)
gdb_group.add_argument(
"-x", "--gdb_cmd_file", help="Execute GDB commands from file."
)
Expand Down Expand Up @@ -864,6 +853,26 @@ def main():
"Pass this flag when debugging gdbgui itself to automatically reload the server when changes are detected",
action="store_true",
)

args_group.add_argument(
"cmd",
nargs='?',
type=lambda prog : [prog],
help='Name of the binary to run in gdb. To pass flags to the binary,'
' use --args instead.'
' Example: gdbgui ./mybinary [gdbgui-args...]',
default=[],
)
args_group.add_argument(
"--args",
nargs=argparse.REMAINDER,
help='Specify the executable file and any arguments. All arguments are'
' taken literally, so if used, this must be the last argument'
' passed to gdbgui.'
' Example: gdbgui [...] --args ./mybinary myarg -flag1 -flag2',
default=[],
)

args = parser.parse_args()

initialize_preferences()
Expand All @@ -872,13 +881,7 @@ def main():
print(__version__)
return

if args.cmd and args.args:
print("Cannot specify command and args. Must specify one or the other.")
exit(1)
if args.cmd:
cmd = args.cmd
else:
cmd = args.args
cmd = args.cmd or args.args

app.config["initial_binary_and_args"] = cmd
app.config["rr"] = args.rr
Expand Down