-
Notifications
You must be signed in to change notification settings - Fork 19
Witchcraft error catching #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
.container{ | ||
max-width:300px; | ||
margin:0 auto; | ||
padding:4em 1em; | ||
text-align:center; | ||
h5{ | ||
margin-bottom:2em; | ||
} | ||
} | ||
.logo{ | ||
width:50%; | ||
max-width:80px; | ||
display:block; | ||
margin:0 auto 3em auto; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import * as React from "react"; | ||
import {map, actionsInterface} from "../actions"; | ||
const layoutStyles = require("../Layout.scss"); | ||
const styles = require("./SignIn.scss"); | ||
|
||
const logo = require("../assets/logo.svg"); | ||
|
||
export interface SignInProps { } | ||
export interface SignInState { } | ||
|
||
class SignIn extends React.Component<SignInProps&actionsInterface, SignInState> { | ||
constructor(props: SignInProps){ | ||
super(props); | ||
this.signin = this.signin.bind(this); | ||
} | ||
signin(e: any) { | ||
e.preventDefault(); | ||
this.props.dispatch.user.signin((this.refs.username as HTMLInputElement).value, (this.refs.password as HTMLInputElement).value); | ||
} | ||
render() { | ||
const projects = this.props.appState.projects; | ||
return (<div className={styles.container}> | ||
<img src={logo} className={styles.logo}/><h5>Sign in to Seashell</h5> | ||
<form className="pt-control-group pt-vertical" onSubmit={this.signin}> | ||
<div className="pt-input-group pt-large"> | ||
<span className="pt-icon pt-icon-person"></span> | ||
<input type="text" className="pt-input" ref="username" placeholder="Username" /> | ||
</div> | ||
<div className="pt-input-group pt-large"> | ||
<span className="pt-icon pt-icon-lock"></span> | ||
<input type="password" className="pt-input" ref="password" placeholder="Password" /> | ||
</div> | ||
<button className="pt-button pt-large pt-intent-primary">Sign In</button> | ||
</form> | ||
|
||
</div>); | ||
} | ||
} | ||
|
||
export default map(SignIn); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's the point of this class? It just sets
__proto__
to Error?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fix to repair the prototype chain so instanceof works properly. See #721.