Skip to content

Set explicit version for Microsoft.AspNetCore.App in Test Project to fix build errors #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

Franklin89
Copy link
Contributor

This PR should fix the Build Errors you were having on the last stream after setting an implicit version.

There are two workarounds at the moment:

  1. Change the test project's tag in the first line to use the web SDK (Microsoft.NET.Sdk.Web instead of Microsoft.NET.Sdk) and add a package reference to Microsoft.AspNetCore.App (or .All if you are using that inside the web project) without specifying a version
  2. Leave the Sdk as-is and add a PackageReference to the shared framework package but specify a version.

This PR uses the second workaround.

@natemcmaster if you have time could you elaborate on the reason why exactly it is required and what the future plan is?

More details and discussions:

dotnet/aspnetcore#3307

https://stackoverflow.com/questions/50401152/integration-and-unit-tests-no-longer-work-on-asp-net-core-2-1-failing-to-find-as/50401153#50401153

@natemcmaster
Copy link

if you have time could you elaborate on the reason why exactly it is required and what the future plan is?

Sure, happy to clarify. It is required for the following reasons:

Future plan:

@Franklin89
Copy link
Contributor Author

@natemcmaster thanks a lot 👍

@csharpfritz csharpfritz merged commit 02198dc into csharpfritz:dev Oct 30, 2018
@csharpfritz
Copy link
Owner

Thank you @Franklin89 for fixing this... I now feel more confident in the build results from Azure Build Pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants