results: skip comments in exclude-paths.txt#150
Merged
kdudka merged 1 commit intocsutils:mainfrom Jan 30, 2024
Merged
Conversation
Contributor
Author
|
Just noticed the comment about the sanity check in OSH-508. Will add ... |
Member
|
@stefan-cornelius The code change looks good. Please delimit the commit title with a blank line as suggested in the I propose this as the commit title: |
4fed291 to
66eb473
Compare
kdudka
approved these changes
Jan 30, 2024
This allows comments in the path exlusion regex file. Instead of adding each line as a filtering rule, it skips empty lines and lines starting with a # symbol. Fixes: https://issues.redhat.com/browse/OSH-508 Closes: csutils#150
66eb473 to
9befcc3
Compare
Member
|
@stefan-cornelius Merging, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows comments in the path exlusion regex file. Instead of adding each line as a filtering rule, it skips empty lines and lines starting with a # symbol.
Fixes https://issues.redhat.com/browse/OSH-508