csmock: use the root mock profile property for lock names#151
Merged
lzaoral merged 1 commit intocsutils:mainfrom Feb 27, 2024
Merged
csmock: use the root mock profile property for lock names#151lzaoral merged 1 commit intocsutils:mainfrom
lzaoral merged 1 commit intocsutils:mainfrom
Conversation
kdudka
requested changes
Feb 20, 2024
Member
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Would it make sense to cache the root_path value in the MockWrapper object so that it can be used at other places (e.g. in the semgrep plug-in) without querying it again?
Member
Author
|
All suggestions addressed in or obsoleted by 87dfa62. |
kdudka
reviewed
Feb 20, 2024
kdudka
reviewed
Feb 26, 2024
lzaoral
force-pushed
the
mock-root-locking
branch
from
9b24649 to
5a0d5c1
Compare
kdudka
reviewed
Feb 26, 2024
kdudka
approved these changes
Feb 27, 2024
Member
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Works as expected now. Thanks!
To fix a crash when two mock profile configuration files have different names but use the same root directory: ``` [...] >>> 2024-02-19 14:29:12 "/usr/bin/mock" "-r" "/tmp/tmpyfvruenl/mock.cfg" "--plugin-option=tmpfs:keep_mounted=True" "--config-opts=print_main_output=True" "--init" INFO: mock.py version 5.2 starting (python version = 3.9.18, NVR = mock-5.2-1.kdudka.5.el9), args: /usr/libexec/mock/mock -r /tmp/tmpyfvruenl/mock.cfg --plugin-option=tmpfs:keep_mounted=True --config-opts=print_main_output=True --init Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: clean chroot ERROR: Build root is locked by another process. !!! 2024-02-19 14:29:13 warning: failed to init mock profile (/tmp/tmpyfvruenl/mock.cfg), trying to scrub cache... [...] ``` Resolves: openscanhub/openscanhub#228 (comment)
lzaoral
force-pushed
the
mock-root-locking
branch
from
be08b57 to
b2c7201
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix a crash when two mock profile configuration files have different names but use the same root directory:
Resolves: openscanhub/openscanhub#228 (comment)