csmock: make kfp work for quarkus-registry.quarkus.redhat.com#158
Closed
kdudka wants to merge 1 commit intocsutils:mainfrom
Closed
csmock: make kfp work for quarkus-registry.quarkus.redhat.com#158kdudka wants to merge 1 commit intocsutils:mainfrom
kdudka wants to merge 1 commit intocsutils:mainfrom
Conversation
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Apr 22, 2024
The code that extracts package name from the name-version-release string did not work as expected if the has suffix started with a digit. Consequently, it did not find the corresponding `exclude-paths.txt` file in the known-false-positives while scanning a source code tarball named: `quarkus-registry.quarkus.redhat.com-01fec5413626d669361dcb0bf921e297be6afdf7.tar.gz` Related: https://issues.redhat.com/browse/OSH-392 Resolves: https://issues.redhat.com/browse/OSH-623 Closes: csutils#158
|
Any chance to have this integrated soon? |
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Apr 23, 2024
The code that extracts package name from the name-version-release string did not work as expected if the hash suffix started with a digit. Consequently, it did not find the corresponding `exclude-paths.txt` file in the known-false-positives while scanning a source code tarball named: `quarkus-registry.quarkus.redhat.com-01fec5413626d669361dcb0bf921e297be6afdf7.tar.gz` Related: https://issues.redhat.com/browse/OSH-392 Resolves: https://issues.redhat.com/browse/OSH-623 Closes: csutils#158
hanchuntao
reviewed
Apr 24, 2024
The code that extracts package name from the name-version-release string did not work as expected if the hash suffix started with a digit. Consequently, it did not find the corresponding `exclude-paths.txt` file in the known-false-positives while scanning a source code tarball named: `quarkus-registry.quarkus.redhat.com-01fec5413626d669361dcb0bf921e297be6afdf7.tar.gz` Related: https://issues.redhat.com/browse/OSH-392 Resolves: https://issues.redhat.com/browse/OSH-623 Closes: csutils#158
hanchuntao
approved these changes
Apr 24, 2024
Member
Author
|
@hanchuntao Thanks for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that extracts package name from the name-version-release string did not work as expected if the hash suffix started with a digit. Consequently, it did not find the corresponding
exclude-paths.txtfile in the known-false-positives while scanning a source code tarball named:quarkus-registry.quarkus.redhat.com-01fec5413626d669361dcb0bf921e297be6afdf7.tar.gzRelated: https://issues.redhat.com/browse/OSH-392
Resolves: https://issues.redhat.com/browse/OSH-623