Conversation
Author
lzaoral
requested changes
May 6, 2024
Member
lzaoral
left a comment
lzaoral
left a comment
There was a problem hiding this comment.
Thnak you, @petr-matousek The clippy plugin now works on RHEL 8 as well!
Remarks:
- nit: The commit message for c34fe3a looks incomplete. 🤔
- I have found out that if the conversion script fails,
csmockwill still exit with0which is quite unexpected. Could you please fix that as well? Thank you!
lzaoral
reviewed
May 14, 2024
petr-matousek
force-pushed
the
rust-clippy
branch
from
fb2ebd6 to
67cdf36
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
petr-matousek
force-pushed
the
rust-clippy
branch
9 times, most recently
from
b029d58 to
0b6b5dc
Compare
Member
|
/packit rebuild-failed |
lzaoral
approved these changes
May 27, 2024
Member
lzaoral
left a comment
lzaoral
left a comment
There was a problem hiding this comment.
LGTM! Thank you @petr-matousek!
walrus operator was introduced in Python 3.8 but we support distributions that have Python versions lower than that.
remove the workaround for the byte-compilation of python scripts in unversioned directories and replace it with the recommended approach from Fedora's Pyhon Packaging Guidelines.
Member
|
Merging, thank you both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a follow up to #157