clippy: make the wrapper work if build is not the 1st arg#170
Merged
kdudka merged 1 commit intocsutils:mainfrom May 29, 2024
Merged
clippy: make the wrapper work if build is not the 1st arg#170kdudka merged 1 commit intocsutils:mainfrom
build is not the 1st arg#170kdudka merged 1 commit intocsutils:mainfrom
Conversation
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
May 28, 2024
... so that we can successfully scan the Rust code
in `librsvg2-2.50.7-1.el9_0` where `cargo` is invoked
like this:
```
cd ./librsvg && \
PKG_CONFIG_ALLOW_CROSS=1 \
PKG_CONFIG='/usr/bin/x86_64-redhat-linux-gnu-pkg-config' \
CARGO_TARGET_DIR=/builddir/build/BUILD/librsvg-2.50.7/target \
cargo --locked build --verbose --release \
&& cd /builddir/build/BUILD/librsvg-2.50.7 && /bin/sh ./libtool [...]
```
Related: https://issues.redhat.com/browse/OSH-30
Closes: csutils#170
kdudka
force-pushed
the
clippy-locked-build
branch
from
75405aa to
bcca9da
Compare
lzaoral
approved these changes
May 28, 2024
... so that we can successfully scan the Rust code
in `librsvg2-2.50.7-1.el9_0` where `cargo` is invoked
like this:
```
cd ./librsvg && \
PKG_CONFIG_ALLOW_CROSS=1 \
PKG_CONFIG='/usr/bin/x86_64-redhat-linux-gnu-pkg-config' \
CARGO_TARGET_DIR=/builddir/build/BUILD/librsvg-2.50.7/target \
cargo --locked build --verbose --release \
&& cd /builddir/build/BUILD/librsvg-2.50.7 && /bin/sh ./libtool [...]
```
Related: https://issues.redhat.com/browse/OSH-30
Closes: csutils#170
kdudka
force-pushed
the
clippy-locked-build
branch
from
bcca9da to
b037156
Compare
lzaoral
approved these changes
May 29, 2024
Member
Author
|
@lzaoral Thanks for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... so that we can successfully scan the Rust code in
librsvg2-2.50.7-1.el9_0wherecargois invoked like this:Related: https://issues.redhat.com/browse/OSH-30