clippy: do not fail the scan if clippy fails to install#174
Merged
kdudka merged 2 commits intocsutils:mainfrom Jun 19, 2024
Merged
clippy: do not fail the scan if clippy fails to install#174kdudka merged 2 commits intocsutils:mainfrom
kdudka merged 2 commits intocsutils:mainfrom
Conversation
The name was confusing because, when the hook is triggered, clippy has already been installed by dnf/rpm.
If the `clippy` package is not available in the build repos, a warning is emitted and `clippy` is not recorded as an enabled tool in the scan properties. But the scan continues without `clippy` in this case. The approach is similar to what `--gcc-analyze` does. This is needed because `clippy` is not available for each mock config and we do not want to configure the set of enabled tools separately for each mock config. Related: https://issues.redhat.com/browse/OSH-30 Closes: csutils#174
lzaoral
approved these changes
Jun 19, 2024
Member
Author
|
@lzaoral Thanks for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
clippypackage is not available in the build repos, a warningis emitted and
clippyis not recorded as an enabled tool in the scanproperties. But the scan continues without
clippyin this case.The approach is similar to what
--gcc-analyzedoes. This is neededbecause
clippyis not available for each mock config and we do notwant to configure the set of enabled tools separately for each mock
config.
Related: https://issues.redhat.com/browse/OSH-30