results: fix quoting in handle_known_fp_list()#183
Merged
kdudka merged 1 commit intocsutils:mainfrom Aug 19, 2024
Merged
Conversation
... by using `shlex.quote()` from standard Python library. This bug
caused regular expressions with parentheses to be interpreted by shell:
```
/bin/sh: -c: line 1: syntax error near unexpected token `('
```
Also avoid using the open-coded `shell_quote()` function from `util.py`
while printing shell commands in `exec_cmd()` because the function is
rather problematic and should be eventually unimplemented.
Unfortunately, we cannot easily nest `shlex.quote()` while combining
`mock --chroot ...` with `su -c ...` and the like because it results
in totally unreadable `scan.log`.
Resolves: https://issues.redhat.com/browse/OSH-617
Closes: csutils#183
rhyw
approved these changes
Aug 17, 2024
Contributor
rhyw
left a comment
rhyw
left a comment
There was a problem hiding this comment.
I also scheduled a task on stage, although the task is still failed, the error message in question is gone.
LGTM
Member
Author
|
@rhyw Thank you for the review and testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... by using
shlex.quote()from standard Python library. This bug caused regular expressions with parentheses to be interpreted by shell:Also avoid using the open-coded
shell_quote()function fromutil.pywhile printing shell commands inexec_cmd()because the function is rather problematic and should be eventually unimplemented.Unfortunately, we cannot easily nest
shlex.quote()while combiningmock --chroot ...withsu -c ...and the like because it results in totally unreadablescan.log.Resolves: https://issues.redhat.com/browse/OSH-617