packaging: create the plugin-shellcheck-core subpackage

[kdudka]

... so that one can easily install the run-shellcheck.sh script without unnecessary dependencies on mock etc.

Related: https://issues.redhat.com/browse/OSH-738

[rhyw]

I tried on a rhel9 server, the csmock-plugin-shellcheck-core can be installed without bringing additional deps. here's the files installed:

[root@2006276284f1 src]# rpm -ql csmock-plugin-shellcheck-core
/usr/share/csmock
/usr/share/csmock/scripts
/usr/share/csmock/scripts/run-shellcheck.sh
/usr/share/licenses/csmock-plugin-shellcheck-core
/usr/share/licenses/csmock-plugin-shellcheck-core/COPYING

I also installed the csmock-plugin-shellcheck with rpm -i --nodeps:

[root@2006276284f1 src]# rpm -ql csmock-plugin-shellcheck
/usr/lib/python3.9/site-packages/csmock/plugins/__pycache__/shellcheck.cpython-39.opt-1.pyc
/usr/lib/python3.9/site-packages/csmock/plugins/__pycache__/shellcheck.cpython-39.pyc
/usr/lib/python3.9/site-packages/csmock/plugins/shellcheck.py

Comparing with the previous csmock-plugin-shellcheck-3.7.0-1.el9.noarch.rpm package:

[root@8217478ad3a7 src]# rpm -ql csmock-plugin-shellcheck-3.7.0-1.el9
/usr/lib/python3.9/site-packages/csmock/plugins/__pycache__/shellcheck.cpython-39.opt-1.pyc
/usr/lib/python3.9/site-packages/csmock/plugins/__pycache__/shellcheck.cpython-39.pyc
/usr/lib/python3.9/site-packages/csmock/plugins/shellcheck.py
/usr/share/csmock/scripts/run-shellcheck.sh

I can see the difference is that /usr/share/licenses/csmock-plugin-shellcheck-core/COPYING is installed along with the -core package. Assuming it's the intended change, this looks good to me.

I tried later by running the script, /usr/share/csmock/scripts/run-shellcheck.sh * or /usr/share/csmock/scripts/run-shellcheck.sh . all gives desired output to shellcheck-results directory.

Note that since it's not running in a chroot environment, we'll need to install shellcheck for the script to run correctly. Otherwise:

+ timeout 30 shellcheck --format=json test/script/e2e_run.sh
timeout: failed to run command 'shellcheck': No such file or directory
+ timeout 30 shellcheck --format=json test/script/ocm.sh
+ timeout 30 shellcheck --format=json test/script/e2e_setup.sh
timeout: failed to run command 'shellcheck': No such file or directory
timeout: failed to run command 'shellcheck': No such file or directory
timeout: failed to run command 'shellcheck': No such file or directory
+ timeout 30 shellcheck --format=json test/script/util.sh
timeout: failed to run command 'shellcheck': No such file or directory

I think it's also the desired behavior per our discussion in slack.

LGTM

[kdudka]

@rhyw Thanks for review!

I can see the difference is that /usr/share/licenses/csmock-plugin-shellcheck-core/COPYING is installed along with the -core package. Assuming it's the intended change, this looks good to me.

IIRC, there is a policy in Fedora packaging that each installed package should provide the license file. csmock-plugin-shellcheck depends on csmock-common, which installs the file. However csmock-plugin-shellcheck-core does not have such a dependency so it installs its own copy of the license file.

Note that since it's not running in a chroot environment, we'll need to install shellcheck for the script to run correctly.

I have introduced a weak dependency on ShellCheck in 3d65f58 to make it work out of the box. The overhead for users of csmock -t shellcheck should be minimal and it can be avoided by disabling installation of weak dependencies if needed.

[rhyw]

change 3d65f58 looks good. Thanks for the update!

[kdudka]

@rhyw Thanks for review!