shellcheck: improve handling of ShellCheck internal errors#196
Merged
kdudka merged 2 commits intocsutils:mainfrom Mar 4, 2025
Merged
shellcheck: improve handling of ShellCheck internal errors#196kdudka merged 2 commits intocsutils:mainfrom
kdudka merged 2 commits intocsutils:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Mar 4, 2025
Rather than failing the whole scan, record them in the scan results. Reproducer: ``` csmock -r rhel-7.7.z-x86_64 -f pki-core-10.5.16-7.el7_7.src.rpm -t shellcheck ``` This commit makes the above scan succeed with the following additional finding included in the scan results: ``` Error: SHELLCHECK_WARNING: /usr/sbin/pki-server-nuxwdog: internal error: hGetContents: invalid argument (invalid byte sequence) ``` Closes: csutils#196
Collaborator
|
I have not tested the validness of the introduced Regexp but the new changes looks good to me |
jperezdealgaba
approved these changes
Mar 4, 2025
Rather than failing the whole scan, record them in the scan results. Reproducer: ``` csmock -r rhel-7.7.z-x86_64 -f pki-core-10.5.16-7.el7_7.src.rpm -t shellcheck ``` This commit makes the above scan succeed with the following additional finding included in the scan results: ``` Error: SHELLCHECK_WARNING: /usr/sbin/pki-server-nuxwdog: internal error: hGetContents: invalid argument (invalid byte sequence) ``` Closes: csutils#196
Member
Author
|
@jperezdealgaba Thanks for review! The Testing Farm failures on Fedora Rawhide seem like infrastructure issues: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than failing the whole scan, record them in the scan results.
Reproducer:
This commit makes the above scan succeed with the following additional finding included in the scan results: