Speed up loader by using hstack instead of merge where possible#2126
Merged
Conversation
Codecov ReportBase: 92.75% // Head: 92.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2126 +/- ##
==========================================
- Coverage 92.75% 92.74% -0.01%
==========================================
Files 214 214
Lines 17876 17910 +34
==========================================
+ Hits 16580 16611 +31
- Misses 1296 1299 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
StFroese
reviewed
Nov 19, 2022
StFroese
previously approved these changes
Nov 20, 2022
kosack
approved these changes
Nov 21, 2022
StFroese
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speeds up the
TableLoaderquite a lot. In my quick test, loading the dl2 electron file I produced (96 MB only subarray data) went from 10s to 4.5 seconds although two of four dl2 columns are not ordered correctly, see #2125.