Skip to content

Make number of training events a telescope parameter#2140

Merged
maxnoe merged 3 commits into
masterfrom
n_events_by_tel
Dec 7, 2022
Merged

Make number of training events a telescope parameter#2140
maxnoe merged 3 commits into
masterfrom
n_events_by_tel

Conversation

@maxnoe
Copy link
Copy Markdown
Member

@maxnoe maxnoe commented Nov 26, 2022

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 26, 2022

Codecov Report

Base: 92.75% // Head: 92.76% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (22ea88b) compared to base (0e4ffea).
Patch coverage: 96.55% of modified lines in pull request are covered.

❗ Current head 22ea88b differs from pull request most recent head b5ddb50. Consider uploading reports for the commit b5ddb50 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
+ Coverage   92.75%   92.76%   +0.01%     
==========================================
  Files         216      216              
  Lines       18050    18061      +11     
==========================================
+ Hits        16742    16755      +13     
+ Misses       1308     1306       -2     
Impacted Files Coverage Δ
ctapipe/tools/train_energy_regressor.py 85.50% <80.00%> (+0.21%) ⬆️
ctapipe/core/tests/test_traits.py 99.49% <100.00%> (+0.01%) ⬆️
ctapipe/core/traits.py 93.53% <100.00%> (+0.10%) ⬆️
ctapipe/tools/train_particle_classifier.py 86.90% <100.00%> (+0.31%) ⬆️
ctapipe/io/metadata.py 96.58% <0.00%> (+1.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

nbiederbeck
nbiederbeck previously approved these changes Nov 28, 2022
Comment thread ctapipe/tools/train_energy_regressor.py Outdated
Comment thread ctapipe/core/traits.py
@maxnoe
Copy link
Copy Markdown
Member Author

maxnoe commented Dec 7, 2022

@kosack @LukasNickel @nbiederbeck comments addressed

@maxnoe maxnoe merged commit ed5fdcc into master Dec 7, 2022
@maxnoe maxnoe deleted the n_events_by_tel branch December 7, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants