Skip to content

Fix docs build for traitlets 5.8 and array field defaults#2173

Merged
maxnoe merged 4 commits into
masterfrom
field_default
Dec 21, 2022
Merged

Fix docs build for traitlets 5.8 and array field defaults#2173
maxnoe merged 4 commits into
masterfrom
field_default

Conversation

@maxnoe
Copy link
Copy Markdown
Member

@maxnoe maxnoe commented Dec 20, 2022

This fixes an issue we found when building the lstchain docs. Arrays were included with all numbers spanning multiple lines which made the sphinx build fail.

nbiederbeck
nbiederbeck previously approved these changes Dec 21, 2022
@maxnoe maxnoe changed the title Make sure array defaults in repr(Field) are concise Fix docs build for traitlets 5.8 and array field defaults Dec 21, 2022
@maxnoe maxnoe requested a review from nbiederbeck December 21, 2022 14:26
Copy link
Copy Markdown
Contributor

@nbiederbeck nbiederbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry is missing

@maxnoe
Copy link
Copy Markdown
Member Author

maxnoe commented Dec 21, 2022

@nbiederbeck We said that we start with changelogs using towncrier after the next release because we already have merged a lot of PRs without changelog.

@maxnoe maxnoe merged commit e7ee398 into master Dec 21, 2022
@maxnoe maxnoe deleted the field_default branch December 21, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants