Fix unit handling in muon ring_completeness#2197
Merged
Merged
Conversation
maxnoe
force-pushed
the
histogram_units
branch
from
161322f to
bc57ba4
Compare
maxnoe
changed the title
nbiederbeck
approved these changes
Jan 9, 2023
LukasNickel
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Astropy 5.2.1 now checks that arguments to
np.histogramare compatible.We had code that passes something like
np.histogram([1, 2, 3] * u.rad, range=[-np.pi, np.pi]), which now raises an error.fixes #2196