Skip to content

Fix overwrite not working for ctapipe-apply-models#2287

Merged
maxnoe merged 1 commit into
mainfrom
apply_models_overwrite
Mar 14, 2023
Merged

Fix overwrite not working for ctapipe-apply-models#2287
maxnoe merged 1 commit into
mainfrom
apply_models_overwrite

Conversation

@maxnoe
Copy link
Copy Markdown
Member

@maxnoe maxnoe commented Mar 13, 2023

Because there was no alias defined for the HDF5Merger component the --overwrite option had no effect for ctapipe-apply-models.

@maxnoe maxnoe force-pushed the apply_models_overwrite branch from 6223be1 to 7d2833c Compare March 13, 2023 12:42
@maxnoe maxnoe added this to the v0.18.1 milestone Mar 13, 2023
@maxnoe maxnoe force-pushed the apply_models_overwrite branch from 7d2833c to 08af07e Compare March 13, 2023 13:37
@Tobychev
Copy link
Copy Markdown
Contributor

@maxnoe I edited the description with that I guessed the fix was, if you confirm the guess is accurate I can approve.

@maxnoe
Copy link
Copy Markdown
Member Author

maxnoe commented Mar 13, 2023

@Tobychev thanks, yes!

@kosack
Copy link
Copy Markdown
Member

kosack commented Mar 13, 2023

Because there was no alias defined for the HDF5Merger component the --overwrite option had no effect

Doesn't this mean that there simply wasn't an --overwrite option at all in the Tool? if so, passing --overwrite on the command-line should have raised an exception due to an unknown alias, right?

@maxnoe
Copy link
Copy Markdown
Member Author

maxnoe commented Mar 13, 2023

Doesn't this mean that there simply wasn't an --overwrite option at all in the Tool? if so, passing --overwrite on the command-line should have raised an exception due to an unknown alias, right?

The option now lives on the Tool itself, it only needs to be overridden if a tool as a sub-component that also needs the option.

@maxnoe maxnoe merged commit c24f38a into main Mar 14, 2023
@maxnoe maxnoe deleted the apply_models_overwrite branch March 14, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants