Add StatisticsAggregator API#2554
Conversation
|
I'm having some troubles with ruff, which makes pylint fail. Can someone please help? Thanks in advance! |
|
For future reference: the issue was that the pre-commit hook wasn't yet installed for some of the commits. To run it on all files affected by this PR, the solution was: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
We can generalize it more later, but for now this is fine |
maxnoe
left a comment
There was a problem hiding this comment.
monitoring/extractor.py is a new module, it needs to be added to the API docs.
Please add it in docs/api-reference/monitoring/ .
You can check the other files there
I tried to added following the structure of the other modules, but the docs are failing. Can you please have a look @maxnoe? Thanks in advance! |
|
The error is not in the new docs page (these are fine!) but in the docstring of one of the new classes: which are now included in the docs, which is why you didn't see them before. You need double back-ticks in rst for code: |
This PR adds a skeleton API for the statistical calculation of pixel-wise values over a given time interval. The current implementation features two different extraction methods, i.e. a
PlainExtractorbased on numpy functions andSigmaClippingExtractorbased on astropy functions, which are also used inlstchain.I'm marking this PR as a draft because of the following discussion points:
sample_size?Related to #2542.