Processing gain-selected dl1 data with the pixel stats tool#2715
Merged
Conversation
maxnoe
reviewed
Mar 17, 2025
maxnoe
reviewed
Mar 17, 2025
remove redundant check that the column is not None in unit test
Analysis Details1 Issue
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
mexanick
approved these changes
Mar 17, 2025
maxnoe
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that we can not process gain-selected data. This PR is a bug fix for processing gain-selected dl1 data with the pixel stats tool and its components. I extended the unit tests accordingly. Before the unit tests were passing since we did not include the detection of outliers in the pixel tool testing.