treat list[Component] in get_current_config()#2851
Merged
Conversation
Member
Author
|
This might imply also that Tool should inherit from Component, which would clean up some code... But here is just a minimal change, since that might be more complex until we have a better config system (currently Tool inherits from traitlets.config.Application) |
kosack
force-pushed
the
fix_tool_current_config
branch
from
5c3adcd to
0544b12
Compare
maxnoe
reviewed
Oct 7, 2025
maxnoe
reviewed
Oct 7, 2025
Checking all Iterables causes this to also check strings and even EventSources, which is not the correct behavior.
maxnoe
reviewed
Oct 8, 2025
kosack
force-pushed
the
fix_tool_current_config
branch
from
a30fbfc to
e2364fb
Compare
kosack
changed the title
|
Please retry analysis of this Pull-Request directly on SonarQube |
Member
|
Sonarqube complains about code duplication. There is a big block exactly copy/pasted in the tests now. Not sure why the message above fails. |
maxnoe
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2850