Fix muon normalization pixel shapes#2865
Merged
Merged
Conversation
…otons (from muon) incident on the telescope mirror.
…factor in this way.
…e to the mirror radius.
Member
|
You also have the phi0 related changes here. |
Member
Author
|
@maxnoe please have a look now. |
mexanick
reviewed
Oct 20, 2025
|
maxnoe
approved these changes
Oct 20, 2025
mexanick
approved these changes
Oct 21, 2025
ParsonsRD
pushed a commit
to ParsonsRD/ctapipe
that referenced
this pull request
Nov 6, 2025
* Add a function to calculate the trivial solution for the number of photons (from muon) incident on the telescope mirror. * Add the PixelShape. For image_prediction, we fixed the normalization factor in this way. * add Add the PixelShape * Add test for normalisation factor * Enhance the chord_length function by applying modulo two pi * Change the parameter rho to absolute values instead of values relative to the mirror radius. * Add phi0 and change phi signe. * Add phi0. * Documentation update. Add desctiption of phi0. * Remove uncovered code. * Removing unnecessary sign verification and correction. * Add a wrapper to preserve the functional API. * from camel case to snake case * from camel case to snake case * add the bugfix changelog statement * Add the bugfix changelog statement - for chord calculation * Get back to initail intersect_circle API * swap phi and phi0 * remove : Fix the modulo 2 pi for chord calculation. * white space * Prune unrelated elements to pixel shape normalization in the fitter. * Prune unrelated elements to pixel shape normalization in the test * renormalise rho * renames: 2845.bugfix.rst -> 2865.bugfix.rst * deleted : ../docs/changes/2845.bugfix.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to :
#2845