Skip to content

Relax a bit time column requirements for chunking#2889

Merged
maxnoe merged 2 commits into
mainfrom
fix_aggregator_checks
Nov 12, 2025
Merged

Relax a bit time column requirements for chunking#2889
maxnoe merged 2 commits into
mainfrom
fix_aggregator_checks

Conversation

@mexanick
Copy link
Copy Markdown
Contributor

This is needed to allow re-aggregation of already aggregated values, i.e. if we want to produce an OBS_ID-average pedestal or FF image (this is the actual use case leading to this change).

@mexanick mexanick self-assigned this Nov 12, 2025
@mexanick mexanick added this to the v0.28.0 milestone Nov 12, 2025
@mexanick
Copy link
Copy Markdown
Contributor Author

@maxnoe this is a minor change that's needed for the ACADA-LST1 test, and it would be great if can be added to 0.28, but if not - not a problem.

Copy link
Copy Markdown
Member

@TjarkMiener TjarkMiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me! Just keep in mind that OBS_ID-average can be tricky in case we have a second pass in the PixelStatisticsCalculator.

@ctao-sonarqube
Copy link
Copy Markdown

@maxnoe maxnoe merged commit 2a81f78 into main Nov 12, 2025
13 checks passed
@maxnoe
Copy link
Copy Markdown
Member

maxnoe commented Nov 12, 2025

I don't see why this would be needed for the ACADA-LST tests, but the changes itself look fine.

@maxnoe maxnoe deleted the fix_aggregator_checks branch November 12, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants