fix #2893, wrong n_showers when no sim dist in file#2913
Merged
Conversation
If no simulation distribution was present in the file, the fallback was to use the simulation config, but applying the shower reuse was missing. Also adds some more consistency checks.
kosack
force-pushed
the
fix/shower_reuse
branch
from
ad6b04d to
d9d8e57
Compare
kosack
force-pushed
the
fix/shower_reuse
branch
from
eca8381 to
8b0be8f
Compare
Closed
maxnoe
reviewed
Dec 17, 2025
maxnoe
approved these changes
Dec 18, 2025
|
Hckjs
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no simulation distribution was present in the file, the fallback was to use the simulation config, but applying the shower reuse was missing. (see #2893)
Also adds some more consistency checks to ensure we don't make a mistake in the effective area.